-
Notifications
You must be signed in to change notification settings - Fork 121
[iPadOS 26][Woo POS] Adjust Checkout view layout for smaller window heights #16129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iPadOS 26][Woo POS] Adjust Checkout view layout for smaller window heights #16129
Conversation
…ettings Image for card present payments should resize between min and max size depending on the space available
…o properly calculate half of container's width
1a5dea0 to
7280dc6
Compare
|
|
|
I've assigned myself to this one, but most likely I'll handle it after HACK week. Let me know if you would prefer to have it prioritized this week though 🙇 |
|
@iamgabrielma all good. Whenever you have time to test it out and review it 👍 |
|
Version |
iamgabrielma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well! Tested on iPad Pro 12.9 inch running iOS 26.0
The card reader connection button overlaps most screens and some flows, do you know if this is logged already as part of iOS16 work? Happy to open it otherwise.
Thoughts if we still need the min width view with iOS26? If we do, we should also change the text to not mention only split views. I can log that one as well 👍
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame( | ||
| minWidth: PointOfSaleCardPresentPaymentLayout.headerSize.width * 0.3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move/declare this 0.3 somewhere else? Just to avoid magic numbers
|
@iamgabrielma thanks for the review!
It's not logged by design. This iOS 26 works to make views a bit more flexible does not aim to do full small screen support. If we do, then we have a phone POS. I realize that the current views are not 100% optimal when the height is super-small but it's just better to what was before.
Yes, we still do need it. I haven't done any work on supporting more screen widths. This was focused on height.
I'll address it. |
…PointOfSaleCardPresentPaymentLayout
…for-smaller-window-heights

WOOMOB-1248
Description
Make Totals (Checkout) view more adaptable for smaller window heights to support iPadOS 26 window resizing, and smaller iPads like iPad Mini.
I explored a few solutions and settled on this one:
.scrollVerticallyIfNeeded()forTotalsViewcontent so the scrolling would kick in when the content doesn't fit.In most cases, it results in this behavior:
scrollVerticallyIfNeededkicks-inThe visual drawback may be that when scrolling kicks in, the elements return to their full size. However, I found the only way to control this behavior was to inject some sort of environment variable so elements could stay in their most compact size once the content no longer fits. However, it introduced too many changes without a clear benefit.
Steps to reproduce
Testing information
Screenshots
iPad Air Simulator - resizing windows
resizing.windows.mov
iPhone - Previews (to show small window height behavior)
iphone.mov
iPad Mini - Previews (to show small image behavior)
iPad.Mini.mov
iPad Air - Previews (to show full size behavior)
ipad.air.mov
RELEASE-NOTES.txtif necessary.