Skip to content

Performance chart: Replace deprecated plotAreaFrame #16145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

Performance chart: Replace deprecated plotAreaFrame #16145

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9af5db
Replace deprecated plotAreaFrame
itsmeichigo Sep 18, 2025
6eb8a3e
Update release notes
itsmeichigo Sep 18, 2025
a62143b
Remove unused code on Blaze dashboard
itsmeichigo Sep 18, 2025
3b7a05d
Merge branch 'trunk' into woomob-1293-wcios17-store-charts-address-pl…
itsmeichigo Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- [*] Order details: Display only physical items in the Shipping Labels section. [https://github.com/woocommerce/woocommerce-ios/pull/16127]
- [internal] Address deprecated view modifiers usage following iOS17 API updates [https://github.com/woocommerce/woocommerce-ios/pull/16080]
- [internal] POS Modularization: Removed direct ServiceLocator usage within POS by requiring complex Woo app target dependencies to be injected via POS dependency protocols, and moved reusable dependencies to WooFoundation and Yosemite [https://github.com/woocommerce/woocommerce-ios/pull/16132]
- [internal] Replace deprecated code on performance chart [https://github.com/woocommerce/woocommerce-ios/pull/16145]

23.2
-----
Expand Down
3 changes: 0 additions & 3 deletions WooCommerce/Classes/ViewRelated/Dashboard/Blaze/BlazeCampaignDashboardViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,6 @@ private extension BlazeCampaignDashboardViewModel {
self?.updateResults()
}

let productTransformer: (StorageProduct) -> BlazeCampaignProduct = {
BlazeCampaignProduct(storageProduct: $0)
}
productResultsController.onDidChangeContent = { [weak self] in
guard let self else { return }
latestPublishedProduct = productResultsController.fetchedObjects.first
Expand Down
5 changes: 4 additions & 1 deletion WooCommerce/Classes/ViewRelated/Dashboard/StoreStats/StoreStatsChart.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ struct StoreStatsChart: View {
return
}

let xPosition = location.x - geometry[proxy.plotAreaFrame].origin.x
guard let plotFrame = proxy.plotFrame else {
return
}
let xPosition = location.x - geometry[plotFrame].origin.x
guard let date: Date = proxy.value(atX: xPosition) else {
return
}
Expand Down