Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

Closes WOOMOB-1349

Description

This PR catches the error of duplicated GTIN/UPC/EAN/ISBN when saving products and show a user-friend error message instead of generic message.

Testing steps

  1. Log in to a store with existing products.
  2. Edit a product
  3. Scan or manually enter a GTIN/UPC/EAN/ISBN that already exists on another product/variation
  4. Attempt to save the changes
  5. Confirm that a clear error message is displayed.

Testing information

Tested with simulator iPhone 17 iOS 26.

Screenshots

Before After
before after

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 18, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo marked this pull request as ready for review September 18, 2025 09:09
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16146-1bf7cb3
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit1bf7cb3
Installation URL38c7vpehjojko
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo added Enhancement feature: product details Related to adding or editing products, including Product Settings. labels Sep 18, 2025
@itsmeichigo itsmeichigo added this to the 23.3 milestone Sep 18, 2025
@itsmeichigo itsmeichigo merged commit 959c8ac into trunk Sep 19, 2025
22 of 24 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1349-ios-app-shows-generic-network-error-instead-of-user-friendly branch September 19, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement feature: product details Related to adding or editing products, including Product Settings.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants