Skip to content

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Sep 18, 2025

Description

Continuation of #16148.

The goal of this PR is to finalize the changes:

  1. ✅ Create PointOfSale module
  2. ✅ Move all the POS files (except the Adaptors and TabBar)
  3. Keep building and resolving remaining dependency errors until the PointOfSale module target succeeds
  4. Then make required PointOfSale entities public so WooCommerce target would succeed. Mostly the dependencies for POSTabCoordinator that creates the entry point. import module PointOfSale
  5. Once it succeeds, move WooCommerceTests to PointOfSaleTests, fix import issues, make sure tests succeed.
  6. See if any adjustments required to run tests in CI
  7. Modularization done

Steps to reproduce

Testing information

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added this to the 23.4 milestone Sep 18, 2025
@staskus staskus added type: task An internally driven task. feature: POS labels Sep 18, 2025
@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@staskus
Copy link
Contributor Author

staskus commented Sep 18, 2025

@jaclync if you're interested, this could be a point of work, to continue and try finalizing the modularization.

Checking out this branch and seeing what is missing to make PointOfSale module build (see description). Hopefully, no more large dependencies need to be addressed to make the module build but hard to be sure.

@jaclync
Copy link
Contributor

jaclync commented Sep 19, 2025

@staskus 👋 Just an update that I'm still in the middle of tackling build errors (Keep building and resolving remaining dependency errors until the PointOfSale module target succeeds step in this PR description). As you probably know, not all errors are shown at once but come up after fixing in batches 😅. I aim to fix all of them locally based on this branch first, then commit the changes for trunk in a separate PR. I plan to wrap up the changes on Monday, but due to the meetup, feel free to come back to it after the meetup.

@staskus
Copy link
Contributor Author

staskus commented Sep 19, 2025

@jaclync, thanks for the work and the update! I'm hopeful we're close to making it happen 🤞 Once the errors are tackled, the main work is done.

@staskus staskus closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants