Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Sep 23, 2025

Closes WOOMOB-1374

Description

This PR adds new Booking entity to Core Data for persisting bookings in the local storage.

Testing steps

The new entity is not used yet so just CI passing is sufficient. You can also try building the app from an existing build from trunk to ensure migration succeeds.

Testing information

Added migration test for Core Data model version 126 to 127.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.4 milestone Sep 23, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Sep 23, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 23, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 23, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16167-8d60c5d
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commit8d60c5d
Installation URL1dpml9eh1njv0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review September 23, 2025 11:23
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from woomob-1374-update-networking-layer-to-support-fetching-bookings to trunk September 24, 2025 08:29
@itsmeichigo itsmeichigo merged commit 82c7879 into trunk Sep 24, 2025
15 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1375-update-storage-layer branch September 24, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants