-
Notifications
You must be signed in to change notification settings - Fork 121
Bookings: Add booking list UI #16177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
| case cancelled | ||
| case pendingConfirmation = "pending-confirmation" | ||
| case confirmed | ||
| case inCart = "in-cart" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This status seems to not be supported so I'm removing it.
| pageNumber: pageNumber, | ||
| pageSize: pageSize) | ||
| await upsertStoredBookingsInBackground(readOnlyBookings: bookings, siteID: siteID) | ||
| let shouldDeleteExistingBookings = pageNumber == Default.firstPageNumber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to clear obsolete items.
|
Converted to draft to better support tabs. |
|
The UX of the tabs is weird so I'll hold off updating that. Making this PR ready again. |
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a non-blocking comment.
| } | ||
| } | ||
| } | ||
| .refreshable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be a way to trigger a refresh from an empty state? I emulated an empty list response. Looks like there is no way to trigger the pull-to-refresh when the "No bookings found" is presented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I updated WOOMOB-1394 to add a point about pull-to-refresh.
| func statusBadge(text: String, color: Color) -> some View { | ||
| Text(text) | ||
| .font(.caption2) | ||
| .padding(.horizontal, 8) | ||
| .padding(.vertical, 4) | ||
| .background(color.clipShape(RoundedRectangle(cornerRadius: 4))) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about making this reusable since the details screen has the same header. I'll do that when it's merged.

Closes WOOMOB-1391
Description
This PR adds the basic UI for the booking list including:
A few things to be updated later:
Known issues from my testing with simulator iOS 26:
I'm keeping the current implementation for now to focus on wrapping the feature first.
Testing steps
Testing information
Tested with simulator iPhone 17 iOS 26.
Screenshots
RELEASE-NOTES.txtif necessary.