Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Sep 30, 2025

WOOMOB-1306

Description

Replaces old deprecated traitCollectionDidChange(_:) override with model API alternative to resolve warnings.

Testing steps

  • Invoke any notice toast presentation. For example switch between stores in "Menu" -> Store selector.
  • Wait until the "Switched to " toast is presented.
  • While the toast is presented rotate the device to landscape mode and back.
  • Make sure the toast is properly resized.

Testing information

Tested on iOS 26 iPhone 17 simulator.

Screenshots

Portrait Landscape
image image

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.4 milestone Sep 30, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Sep 30, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16182-0807570
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commit0807570
Installation URL5v9e9bcku2tho
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Oct 1, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@RafaelKayumov RafaelKayumov merged commit 72174e5 into trunk Oct 1, 2025
18 of 19 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1306-update-trait-observing-API-in-notice-presenter branch October 1, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants