Skip to content

[Bookings][Part 4] Booking details screen #16192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 3, 2025
Merged

[Bookings][Part 4] Booking details screen #16192

merged 6 commits into from
Oct 3, 2025
+189 −3

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Oct 1, 2025 •
edited
Loading

Part of: WOOMOB-1236

Description

In this PR the work on the "Booking details" is continued. Previous PR: #16191.

  • Adds dialogue for ellipsis item: "Mark as paid", "View order", "Cancel booking". Actions callbacks aren't yet handled - only prints logs to console.
  • Adds "Attendance status" selection view. Presents "Booked", "Checked-in", "No-show" tappable options. Options callbacks aren't yet handled. Only prints logs to console.

Steps to reproduce

  • Use CIAB site with bookings
  • Go to bookings list
  • Tap on a booking to open details screen
  • Scroll down to "Attendance" section and tap on "Status" row
  • The status selection view should appear
  • Make sure the selection sheet appearance matches design
  • Make sure that tapping on an options there makes the sheet disappear.
  • Make sure that the corresponding option is printed to console.

Testing information

Tested on iOS 26 iPhone 17 Simulator

Screenshots

Снимок экрана 2025-10-01 в 18 23 41 Снимок экрана 2025-10-01 в 18 23 27
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.4 milestone Oct 1, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Oct 1, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 1, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16192-198f3e5
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commit198f3e5
Installation URL3dnin2638pi7o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Base automatically changed from WOOMOB-1236-booking-details-part-3 to trunk October 2, 2025 12:52
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 2, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo self-assigned this Oct 2, 2025
itsmeichigo
itsmeichigo reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attendance sheet looks good in normal font but seems to break when using a large font on the phone:

Simulator Screenshot - iPhone 17 - 2025-10-02 at 21 42 11

How about using a scroll view and enable large detent in case it's needed?

@RafaelKayumov
Copy link
Contributor Author

RafaelKayumov commented Oct 2, 2025

The attendance sheet looks good in normal font but seems to break when using a large font on the phone:

Simulator Screenshot - iPhone 17 - 2025-10-02 at 21 42 11 How about using a scroll view and enable large detent in case it's needed?

I embedded the content in scroll view, and also made the sheet expandable. Could you please take another look?

iPad.demo.mov
iPhone.demo.mov

itsmeichigo
itsmeichigo approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@RafaelKayumov RafaelKayumov merged commit 9dfa610 into trunk Oct 3, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1236-booking-details-part-4 branch October 3, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.4

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelKayumov @wpmobilebot @dangermattic @itsmeichigo