-
Notifications
You must be signed in to change notification settings - Fork 121
Bookings: Fetch filtered bookings on time tabs #16206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left just 1 UI related comment
| tabCount: BookingListTab.allCases.count, | ||
| selectedIndex: viewModel.selectedTab.rawValue)) | ||
| selectedIndex: viewModel.selectedTab.rawValue), | ||
| y: -Layout.selectedTabIndicatorHeight / 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be + for the indicator Y? In my testing the - lifts the indicator even higher from the view bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! I'll fix this in the next PR #16211.

Closes WOOMOB-1392
Description
This PR wraps up the tabs on the booking list. Changes include:
Testing steps
Testing information
Screenshots
Simulator.Screen.Recording.-.iPhone.17.-.2025-10-03.at.18.18.23.mov
RELEASE-NOTES.txtif necessary.