[Bookings] Customer data for Booking Details #16214

RafaelKayumov · 2025-10-06T16:57:07Z

Part of: WOOMOB-1426

Description

Loads and displays customer data in Booking Details screen.

Adds loadCustomer as CustomerAction that fetches local Storage.Customer with given site ID and customer ID.
Replaces customerDetailsView method with distinct CustomerDetailsView for better data binding and code organizing.
Adds BookingDetailsViewModel.CustomerContent as a model for CustomerDetailsView as an ObservableObject with @Published properties.
In BookingDetailsViewModel implements customer data local fetching and API syncing.
Implements customer email copying to pasteboard on row tap.

Testing steps

Use a testing CIAB site with bookings
Navigate to Bookings tab
Locate a booking that contains a customer with non-empty readable content like name, email, phone and address.
Select the booking and navigate to details view.
Make sure the "Customer" section appears upon loading.
Make sure the "Customer" section contains correct data.
Locate a booking that doesn't have a customer / Or simulate this condition by setting customerID to 0 in bookings response by using Proxyman.
Select the booking and navigate to details view.
Make sure the "Customer" section disappeared.
Select the 1st booking with the valid customer details again and make sure the "Customer" section re-appeared.
Also in Booking Details with valid Customer section data - tap on email row that presents the "copy" icon. Make sure the email is copied to clipboard and the confirmation toast is presented.

Testing information

Tested on iOS 26 iPhone 17 and iPad simulators.

Screenshots

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

dangermattic · 2025-10-06T16:57:45Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2025-10-06T17:06:41Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr16214-7c2634e`
	Version	`23.4`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`7c2634e`
	Installation URL	7kgqiu1l7t9ng

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

# Conflicts: # WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift # WooCommerce/WooCommerce.xcodeproj/project.pbxproj

itsmeichigo

Tested with iPhone 17 simulator and confirmed that this works as expected. I left some nit-picking comments below.

Irrelevant to the PR: Please force the date and time displayed in the detail screen to use UTC like on the booking list as suggested in the thread p1759398245019489-slack-C09FHQNQERG. Currently, we're displaying different time on the two screens.

itsmeichigo · 2025-10-09T06:53:28Z

WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift

 import struct Networking.Booking
+import struct Networking.Customer
+import struct Networking.Address


Nit: It's not necessary to import these models from Networking as they are exported from Yosemite in Model.

Removed in be1c572

itsmeichigo · 2025-10-09T07:09:53Z

WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift

+        withAnimation {
+            sections.insert(customerSection, at: 2)
+        }


While running the app with Xcode, I saw a warning for this update: "Publishing changes from background threads is not allowed; make sure to publish values from the main thread (via operators like receive(on:)) on model updates." Please consider marking updateCustomerSection with @MainActor.

Added in the other PR in 2fee1b9726fe4b46d0732e83134d29de90e860eb

itsmeichigo · 2025-10-09T07:12:35Z

WooCommerce/Classes/ViewRelated/Bookings/Booking Details/CustomerDetailsView.swift

+                    .foregroundStyle(Color.accentColor)
+            }
+            .padding(.vertical, Layout.rowTextVerticalPadding)
+            .tappable {


Looks like the tap works only on image and text and not in the spacing in the middle. Please consider adding contentShape for the content in TappableViewModifier.

Added in 396a379

itsmeichigo · 2025-10-09T07:14:10Z

WooCommerce/Classes/ViewRelated/Bookings/Booking Details/CustomerDetailsView.swift

+            }
+            .padding(.vertical, Layout.rowTextVerticalPadding)
+            .tappable {
+                print("On phone ellipsis")


Should this be handled in this PR or a subsequent one? It may be necessary to hide the call button if a device does not support calling.

I'll implement that in a separate PR

itsmeichigo · 2025-10-09T07:16:03Z

WooCommerce/Classes/ViewRelated/Bookings/Booking Details/CustomerDetailsView.swift

+                let notice = Notice(title: Localization.emailCopiedMessage, feedbackType: .success)
+                ServiceLocator.noticePresenter.enqueue(notice: notice)


Nit: We can also use the .notice modifier instead of using the singleton.

Reworked in 7c2634e

…active

…s view

Fetch and display customer content in booking details

a55d195

RafaelKayumov added this to the 23.5 milestone Oct 6, 2025

RafaelKayumov added the type: task An internally driven task. label Oct 6, 2025

RafaelKayumov added 8 commits October 7, 2025 13:52

Trigger data sync on init

70eaee2

Load local customer for booking details

98a2c9d

Rework customer details content view for proper divider rendering

24bafde

Copy email to pasteboard

dde7555

Add test for customer content

1dd7b07

Merge branch 'trunk' into WOOMOB-1426-load-and-apply-cusromer-data

c44fc42

# Conflicts: # WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift # WooCommerce/WooCommerce.xcodeproj/project.pbxproj

Bring back Billing Address title

0d27940

Delete unused import

00b2184

RafaelKayumov marked this pull request as ready for review October 7, 2025 21:49

Remove customer section absence as sync condition

7f122e2

RafaelKayumov mentioned this pull request Oct 8, 2025

[Bookings] Apply customer data to header #16226

Merged

1 task

RafaelKayumov requested a review from itsmeichigo October 8, 2025 15:11

itsmeichigo self-assigned this Oct 9, 2025

itsmeichigo approved these changes Oct 9, 2025

View reviewed changes

RafaelKayumov added 3 commits October 9, 2025 14:44

Delete unnecessary imports

be1c572

Apple contentShape modifier for tappable to have the whole area inter…

396a379

…active

Use .notice view modifier and pass notice presented to booking detail…

7c2634e

…s view

RafaelKayumov force-pushed the WOOMOB-1426-load-and-apply-cusromer-data branch from a9ec0aa to 7c2634e Compare October 9, 2025 12:37

RafaelKayumov merged commit 4e1797b into trunk Oct 9, 2025
16 checks passed

RafaelKayumov deleted the WOOMOB-1426-load-and-apply-cusromer-data branch October 9, 2025 13:00

RafaelKayumov mentioned this pull request Oct 13, 2025

[Bookings] Booking details part 7 #16234

Merged

1 task

		let notice = Notice(title: Localization.emailCopiedMessage, feedbackType: .success)
		ServiceLocator.noticePresenter.enqueue(notice: notice)

[Bookings] Customer data for Booking Details #16214

[Bookings] Customer data for Booking Details #16214

Uh oh!

Conversation

RafaelKayumov commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing steps

Testing information

Screenshots

Uh oh!

dangermattic commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsmeichigo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RafaelKayumov commented Oct 6, 2025 •

edited

Loading

dangermattic commented Oct 6, 2025 •

edited

Loading

wpmobilebot commented Oct 6, 2025 •

edited

Loading