-
Notifications
You must be signed in to change notification settings - Fork 121
Bookings: Add search functionality for booking list #16215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
…' into woomob-1393-booking-list-search
|
Converted to draft as the design has changed 🤦 |
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described. Pre approving.
Just some thoughts:
Are we aiming to persist lists state when opening search? Initially I was thinking about just extending the existing lists by adding search capabilities. I.e. entering the search mode would have meant using the same lists but just displaying the search bar and applying the search term.
Another question - is it possible to animate the list as just a "lift up" when search mode is opening? I'm not sure how flexible is the animation there.
Currently the navigation bar turns into the thinner search bar, so the list shifts up a bit. But the animation looks like:
- Open search: List fade out + Search fade in
- Close search: List re-appear lower and fade in + move up
AnimationDemo.mov
My idea is to keep a separation of concern as the search mode requires only networking data (no storage) while pagination is needed. I started out keeping search state in the booking list but then it ended up with a lot of conditional checks, so I moved the search states to a separate view model for easier maintainance.
My current solution is a workaround to show/hide the search bar, which comes with a rather abrupt animation. The default behavior with Since our deadline is tight, how about keeping the current behavior and revisit the UX later when the first iteration is shipped? Also, if you have some suggestion on how we can implemented the desired UX, please also share it and we can implement it later. |
|
@RafaelKayumov I fixed the animation issue by moving the Edit: actually the search bar cannot be hidden again after dismissing search. I'm not sure which UX is better. |
Unfortunately I don't have a solution on top of my mind. I experimented with the Let's unroll the f440191 and go as-is for now :( |
This reverts commit f440191.

Closes WOOMOB-1393
Description
This PR adds the search functionality for booking list:
Apologies for the large changes, half of them come from tests.
Testing steps
Testing information
Screenshots
Simulator.Screen.Recording.-.iPhone.17.-.2025-10-09.at.10.11.49.mov
RELEASE-NOTES.txtif necessary.