Skip to content

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Oct 7, 2025

Description

WOOMOB-1417, WOOMOB-1419

A few fixes:

  • Improved search bar animation
  • Spacing between orders
  • Refunds ordered by creation date (id) in the details
  • Layout breaks when there are no search results

Steps to reproduce

Search Bar Animation

  • The search icon should disappear first, then the field appears. And vice-versa, the field disappears and then search icon appears.

Spacing between orders

  • Spacing between orders should now be 16pt, matching spacing in the details view

Refunds

  1. Create an order on POS with multiple products
  2. Go to Woo app -> Orders or WP-Admin and make two refunds on the same order
  3. Go to POS -> Menu -> Orders
  4. Confirm the refunds appear in the creation order

Layout breaks when there are no search results

  1. If testing on a simulator, make sure the hardware keyboard is disabled
  2. Open POS Orders search
  3. Type a complex query
  4. Confirm error message appears and is visible

Testing information

Tested on iPad Air 11 inch 26 simulator

Screenshots

Fixed: Layout breaks when there are no search results

search.empty.fix.mov

Fixed: Search Animation

Simulator.Screen.Recording.-.iPad.Air.11-inch.M3.-.2025-10-07.at.10.12.47.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added this to the 23.5 milestone Oct 7, 2025
@staskus staskus added type: task An internally driven task. feature: POS labels Oct 7, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 7, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16216-ebae30f
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commitebae30f
Installation URL1heho7kc5qdg0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@staskus staskus marked this pull request as ready for review October 7, 2025 09:28
@staskus
Copy link
Contributor Author

staskus commented Oct 7, 2025

@jaclync / @joshheald - one review is enough

I think these two PRs can be tested together on this branch:

They both address CfT comments and Design improvements.

  • Full-screen empty and error views
  • Split-screen empty and error views when searching
  • Ordered refunds in the details view
  • Spacing between orders
  • Fix of layout breaking when there are no search results
  • Fix of layout breaking when searching and resizing the iPadOS 26 window

No rush, good to wrap-up by the end of the week. Thank you!

@staskus staskus requested review from jaclync and joshheald October 7, 2025 10:53
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The POS orders look very nice, also tested the empty state. 🚀

One minor observation is that the refunded products are still shown in the products section and look the same as other non-refunded products. Maybe there could be a separate section for refunded products, or some visual indication like a reduced item quantity for each refunded product.

POS order order details in the orders tab
Simulator Screenshot - iPad Air 11-inch (M3) - 2025-10-08 at 10 34 34 Simulator Screenshot - iPad Air 11-inch (M3) - 2025-10-08 at 10 34 49

@staskus
Copy link
Contributor Author

staskus commented Oct 8, 2025

@jaclync, thanks!

One minor observation is that the refunded products are still shown in the products section and look the same as other non-refunded products. Maybe there could be a separate section for refunded products, or some visual indication like a reduced item quantity for each refunded product.

Yes, that's true. I planned the refund-related work for the second iteration pdfdoF-86q-p2. It should be a fairly small iteration, hopefully we'll find time to fit it in the next few months.

@staskus staskus changed the base branch from woomob-1409-woo-poshistorical-orders-empty-and-error-states-designer-ui to trunk October 8, 2025 12:58
@staskus staskus merged commit cf01d8c into trunk Oct 8, 2025
14 checks passed
@staskus staskus deleted the woomob-1417-woo-poshistorical-orders-cft-fixes branch October 8, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants