Skip to content

Fix/coupon scrolling #16218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2025
Merged

Fix/coupon scrolling #16218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3997917
Dismiss keyboard on scroll AddEditCouponView
adborbas Oct 7, 2025
46537a7
Dismiss keyboard on scroll CouponRestrictions
adborbas Oct 7, 2025
b09a172
Updaate release notes
adborbas Oct 7, 2025
3667e1b
Merge branch 'trunk' into fix/coupon_scrolling
adborbas Oct 7, 2025
0192577
Merge branch 'trunk' into fix/coupon_scrolling
adborbas Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
23.5
-----
- [internal] POS code was moved to its own module, including POS specific color and image assets. [https://github.com/woocommerce/woocommerce-ios/pull/16176]
- [*] Fix Create Coupon screen scrolling issue. [https://github.com/woocommerce/woocommerce-ios/pull/16218]


23.4
Expand Down
1 change: 1 addition & 0 deletions WooCommerce/Classes/ViewRelated/Coupons/Add and Edit Coupons/AddEditCoupon.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ struct AddEditCoupon: View {
}
}
}
.scrollDismissesKeyboard(.immediately)
}
.sheet(isPresented: $showingSelectProducts) {
ProductSelectorNavigationView(configuration: .productsForCoupons,
Expand Down
1 change: 1 addition & 0 deletions ...ce/Classes/ViewRelated/Coupons/Add and Edit Coupons/UsageDetails/CouponRestrictions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ struct CouponRestrictions: View {
.padding(.horizontal, insets: geometry.safeAreaInsets)
.frame(maxWidth: .infinity, alignment: .leading)
}
.scrollDismissesKeyboard(.immediately)
.background(Color(.listForeground(modal: false)))
.ignoresSafeArea(.container, edges: [.horizontal])
.sheet(isPresented: $showingExcludeProducts) {
Expand Down