-
Notifications
You must be signed in to change notification settings - Fork 121
[Woo POS][Surveys] Store in-app if survey notification has been scheduled #16233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS][Surveys] Store in-app if survey notification has been scheduled #16233
Conversation
|
|
|
@staskus can I pass this one over to you please? I'm out of time today... |
staskus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good!
With POS surveys we want to schedule a notification only once per app install, this PR adds support for storing if this notification has already been sent or not.
Does AppSettingStore works once per app install or gets reset after login/logout?
That's a good question. Initially I though that these would reset on switching sites, but on looking at We also have Triggering conditions are still a bit unclear regarding a merchant that may have multiple sites or if these should be mutually exclusive, and we could have a couple of edge cases here depending on the final spec. I'm confirming with Android what's the expected behavior on p1760339880670259?thread_ts=1760066960.650969&cid=C070SJRA8DP-slack-C070SJRA8DP |

Closes WOOMOB-1461
Description
With POS surveys we want to schedule a notification only once per app install, this PR adds support for storing if this notification has already been sent or not.
Changes
GeneralAppSettingswith a new propertyisPOSSurveyNotificationScheduled.AppSettingsActionwith 3 functions to set, get, and reset the value.Testing
Currently not used, we'll hook it up later. For the moment, CI should pass.