-
Notifications
You must be signed in to change notification settings - Fork 121
[Mobile Payments] Enable card payments using Stripe gateway in the UK #16287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile Payments] Enable card payments using Stripe gateway in the UK #16287
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the Stripe payment gateway in the United Kingdom (GB) for card present payments. Previously, only WooCommerce Payments (WCPay) was supported in the UK, but now both Stripe and WCPay are enabled.
Key changes:
- Updated GB country configuration to include Stripe gateway alongside WCPay
- Added Stripe plugin minimum version requirement (6.2.0) for GB
- Updated test expectations to reflect new multi-plugin behavior in UK
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Modules/Sources/Yosemite/Model/Payments/CardPresentPaymentsConfiguration.swift | Added Stripe gateway ID and minimum version (6.2.0) to GB country configuration |
| Modules/Tests/YosemiteTests/Model/CardPresentConfigurationTests.swift | Updated test to expect both wcpay and stripe payment gateways for GB |
| WooCommerce/WooCommerceTests/ViewRelated/CardPresentPayments/CardPresentPaymentsOnboardingUseCaseTests.swift | Updated test names and assertions to reflect new onboarding behavior when Stripe plugin is installed in UK |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ommerceTests/ViewRelated/CardPresentPayments/CardPresentPaymentsOnboardingUseCaseTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…payments-using-stripe-gateway
joshheald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good and tests well! Approving pending confirmation of allowind TTP in UK.
| } | ||
|
|
||
| func test_onboarding_returns_setup_not_completed_stripe_when_stripe_and_wcPay_plugins_are_installed_in_UK() { | ||
| func test_onboarding_returns_select_plugin_when_stripe_and_wcPay_plugins_are_installed_in_UK() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good place for a parameterised test – since it's identical to the US test other than the country code.
This isn't an expectation for this PR – you can't use it here, because this is all still written for XCTest, the old testing framework. I just thought it was worth letting you know that is possible with iOS tests, if you use SwiftTesting, the newer framework.
Generally, all new test files should use SwiftTesting, and it's nice-to-have to convert tests which we're heavily editing/adding to. I don't think I would in this case, as it's a small change and you don't need to add a lot of tests, but you could if you want to.
Here are some docs – but again, don't feel you have to do this now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing the context about SwiftTesting 🙇

Enable card payments using Stripe gateway in the UK
WOOMOB-1430
Description
This PR enables Stripe Payment Gateway extension in the UK for In-Person Payments and POS.
💡 The public-facing documentation will be updated once the feature is released.
Test Steps
Screenshots
N/A
RELEASE-NOTES.txtif necessary.