Skip to content

[Mobile Payments] Enable card payments using Stripe gateway in the UK #16287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 31, 2025
Merged

[Mobile Payments] Enable card payments using Stripe gateway in the UK #16287

merged 6 commits into from
Oct 31, 2025
+10 −7

Conversation

@samiuelson
Copy link
Contributor

@samiuelson samiuelson commented Oct 28, 2025 •
edited
Loading

Enable card payments using Stripe gateway in the UK

WOOMOB-1430

Description

This PR enables Stripe Payment Gateway extension in the UK for In-Person Payments and POS.

⚠️ Do not merge label - to ensure we release this feature in the same version across Android and iOS
💡 The public-facing documentation will be updated once the feature is released.

Test Steps

  1. Card-present payment collection should be tested using UK-based store, having Stripe Paymen Gateway plugin activated:
  • Test using the WisePad reader with Order Creation (IPP)
  • Test using the WisePad reader with Point of Sale
  • Test using Tap to Pay with Order Creation (IPP) – this is phone-only, so no need to check POS
  • Test onboarding with one and both plugins active on the site — plugin selector should appear.
  1. Link to purchase the card reader — should open the GB site and offer WisePad 3
  2. "Learn more" links — should point to Stripe-specific site rather than WooPayments

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@samiuelson samiuelson added this to the 23.7 milestone Oct 28, 2025
@samiuelson samiuelson added type: task An internally driven task. status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Oct 28, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 28, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16287-91bdd40
Version23.5
Bundle IDcom.automattic.alpha.woocommerce
Commit91bdd40
Installation URL7153siq9g7u58
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@samiuelson samiuelson added feature: mobile payments Related to mobile payments / card present payments / Woo Payments. feature: point of sale labels Oct 29, 2025
@samiuelson samiuelson requested a review from Copilot October 29, 2025 13:24
Copilot AI reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Stripe payment gateway in the United Kingdom (GB) for card present payments. Previously, only WooCommerce Payments (WCPay) was supported in the UK, but now both Stripe and WCPay are enabled.

Key changes:

  • Updated GB country configuration to include Stripe gateway alongside WCPay
  • Added Stripe plugin minimum version requirement (6.2.0) for GB
  • Updated test expectations to reflect new multi-plugin behavior in UK

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Modules/Sources/Yosemite/Model/Payments/CardPresentPaymentsConfiguration.swift Added Stripe gateway ID and minimum version (6.2.0) to GB country configuration
Modules/Tests/YosemiteTests/Model/CardPresentConfigurationTests.swift Updated test to expect both wcpay and stripe payment gateways for GB
WooCommerce/WooCommerceTests/ViewRelated/CardPresentPayments/CardPresentPaymentsOnboardingUseCaseTests.swift Updated test names and assertions to reflect new onboarding behavior when Stripe plugin is installed in UK

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samiuelson
Fix typo
ab76921 
Co-authored-by: Copilot <[email protected]>
@samiuelson samiuelson marked this pull request as ready for review October 29, 2025 14:10
@samiuelson samiuelson requested a review from joshheald October 29, 2025 14:10
@joshheald joshheald self-assigned this Oct 30, 2025
@joshheald joshheald added status: do not merge Dependent on another PR, ready for review but not ready for merge. and removed status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Oct 30, 2025
joshheald
joshheald approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and tests well! Approving pending confirmation of allowind TTP in UK.

...ommerceTests/ViewRelated/CardPresentPayments/CardPresentPaymentsOnboardingUseCaseTests.swift
}

func test_onboarding_returns_setup_not_completed_stripe_when_stripe_and_wcPay_plugins_are_installed_in_UK() {
func test_onboarding_returns_select_plugin_when_stripe_and_wcPay_plugins_are_installed_in_UK() {
Copy link
Contributor

@joshheald joshheald Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good place for a parameterised test – since it's identical to the US test other than the country code.

This isn't an expectation for this PR – you can't use it here, because this is all still written for XCTest, the old testing framework. I just thought it was worth letting you know that is possible with iOS tests, if you use SwiftTesting, the newer framework.

Generally, all new test files should use SwiftTesting, and it's nice-to-have to convert tests which we're heavily editing/adding to. I don't think I would in this case, as it's a small change and you don't need to add a lot of tests, but you could if you want to.

Here are some docs – but again, don't feel you have to do this now!

Copy link
Contributor Author

@samiuelson samiuelson Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the context about SwiftTesting 🙇

@iangmaia iangmaia added status: do not merge Dependent on another PR, ready for review but not ready for merge. and removed status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Oct 30, 2025
@samiuelson samiuelson removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Oct 31, 2025
@samiuelson samiuelson enabled auto-merge October 31, 2025 12:01
@samiuelson samiuelson merged commit 8ed1ad0 into trunk Oct 31, 2025
42 checks passed
@samiuelson samiuelson deleted the woomob-1430-mobile-paymentsios-enable-card-payments-using-stripe-gateway branch October 31, 2025 12:01
@samiuelson samiuelson mentioned this pull request Nov 3, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@joshheald joshheald joshheald approved these changes

Assignees

@joshheald joshheald

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. feature: point of sale type: task An internally driven task.

Projects

None yet

Milestone

23.7

Development

Successfully merging this pull request may close these issues.

5 participants

@samiuelson @wpmobilebot @joshheald @iangmaia