-
Notifications
You must be signed in to change notification settings - Fork 121
[Bookings] Use cached tabs visibility #16292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
1bae8c7 to
c1227b1
Compare
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected, good job!
|
|
||
| // Configures POS tab coordinator once per logged in site session. | ||
| let posTabVisibilityChecker = posTabVisibilityCheckerFactory(site) | ||
| self.posTabVisibilityChecker = posTabVisibilityCheckerFactory(site) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: why don't we set the checker using the local variable?
| self.posTabVisibilityChecker = posTabVisibilityCheckerFactory(site) | |
| self.posTabVisibilityChecker = posTabVisibilityChecker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in dec1f90
# Conflicts: # WooCommerce/Classes/ViewRelated/MainTabBarController.swift

WOOMOB-1486
Description
Applies eligibility/visibility cached values for POS and Booking tabs visibility upon presenting.
BookingsTabEligibilityCheckerPOSTabVisibilityCheckerTest Steps
Site Switching Demo
siteSwitching.mov
App Launching Demo
AppLaunching.mov
RELEASE-NOTES.txtif necessary.