-
Notifications
You must be signed in to change notification settings - Fork 121
Bookings: Enable searching in service/event filter #16294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Not related to the PR: The top divider of the top cell interferes with the header bottom line. Probably the bottom divider of the bottom cell is not needed either:
- I'm not sure if I fully understand the product search results and keywords logic. But trying just the substrings of service names in search gives unexpected results. For example if testing in our shared CIAB site and entering the "Ro" search term I can see both "Room Rental" and "Hair Salon Appointment". Entering "P" also reveals both results. "Re" also both results.
| } else { | ||
| // Keep base predicate if search predicate is not available | ||
| resultsController.predicate = syncable.createPredicate() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and readable. How about making it shorter?
var predicates = [syncable.createPredicate()]
if !query.isEmpty, let searchPredicate = syncable.createSearchPredicate(keyword: query) {
predicates.append(searchPredicate)
}
resultsController.predicate = NSCompoundPredicate(andPredicateWithSubpredicates: predicates)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better - done in ebae5bf.
|
Thanks for the feedback!
Eagle eyes 👀 Fixed in f7ba545.
The logic is that we assign results from remote with the keywords that yield the response. Your observation is correct, but I see the same thing in the remote responses via Proxyman. This PR is ready for another look. |
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thx for the update.

Part of WOOMOB-1240
Description
This PR adds the search capability on the Service / Event filter for bookings. Tests for
SyncableListSelectorViewModelhave also been added.Test Steps
Screenshots
Simulator.Screen.Recording.-.iPad.mini.A17.Pro.-.2025-10-30.at.17.35.39.mov
RELEASE-NOTES.txtif necessary.