Skip to content

Fix product variation selection for order creation #16317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

Fix product variation selection for order creation #16317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52fb0ae
Trigger selection change on dismiss
adborbas Nov 4, 2025
84736e7
Rather use the navigation stack
adborbas Nov 5, 2025
9c56e1d
Update release notes
adborbas Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- [*] Improve card payments onboarding error handling to show network errors correctly [https://github.com/woocommerce/woocommerce-ios/pull/16304]
- [*] Authenticate the admin page automatically for sites with SSO enabled in custom fields, in-person payment setup, and editing tax rates flows. [https://github.com/woocommerce/woocommerce-ios/pull/16318]
- [*] Show POS feedback surveys for eligible merchants [https://github.com/woocommerce/woocommerce-ios/pull/16325]
- [*] Fix product variation selection for order creation [https://github.com/woocommerce/woocommerce-ios/pull/16317]

23.6
-----
Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/Classes/ViewRelated/Orders/Order Creation/OrderForm.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ struct OrderFormPresentationWrapper: View {
},
secondaryView: { isShowingProductSelector in
if let productSelectorViewModel = viewModel.productSelectorViewModel {
ProductSelectorView(configuration: .loadConfiguration(for: horizontalSizeClass),
ProductSelectorNavigationView(configuration: .loadConfiguration(for: horizontalSizeClass),
isPresented: isShowingProductSelector,
viewModel: productSelectorViewModel)
.sheet(item: $viewModel.productToConfigureViewModel) { viewModel in
Expand Down
3 changes: 1 addition & 2 deletions WooCommerce/Classes/ViewRelated/Products/ProductSelector/ProductSelectorNavigationView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@ struct ProductSelectorNavigationView: View {
}

var body: some View {
NavigationView {
NavigationStack {
ProductSelectorView(configuration: configuration,
isPresented: $isPresented,
viewModel: viewModel)
}
.navigationViewStyle(.stack)
.wooNavigationBarStyle()
}
}
Expand Down