Speculative fix for flaky order sync test

[joshheald]

Description

This test has been around for about a year, and there's no recent changes in the area, so I'm not really sure why it's started getting flaky... I also couldn't reproduce it reliably even running the tests thousands of times.

I couldn't see anything obvious, so this is a fairly speculative improvement, but removing the sleep should help.

Test Steps

In Xcode, right click the test suite diamond and select Run Tests repeatedly and run them 1000 times. I tried 5000 with no failures.

Screenshots

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	pr16330-0905082
	Version	23.6
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	0905082
	Installation URL	3oaq27m1mlkvg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[itsmeichigo]

I followed the instruction to run the test 1000 times. It failed in iteration 161 for me:

✘ Test syncOrder_when_already_syncing_doesnt_call_orderService() recorded an issue at PointOfSaleOrderControllerTests.swift:91:9: Expectation failed: (mockOrderService.syncOrderWasCalled → false) == true

Since I don't have enough context on this area, I hope @iamgabrielma can help take a look? 🙏

[joshheald]

Observation is a really good framework for normal use, and kinda bad for testing. Unless anyone has any specific ideas to improve it, I'd vote for removing the test over spending more time on fixing it.

[iamgabrielma]

Changes LGTM. Interestingly running that specific test 1000 times failed once, while running the whole suite 1000 times (25k tests) never failed.

✔ Test run with 25000 tests passed after 35.358 seconds.

For a 0.1% chance I'd keep it, if this becomes a CI issue and starts to happen often I'd say let's just remove it.