-
Notifications
You must be signed in to change notification settings - Fork 121
Fix Order Details presentation on phone #16331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Order Details presentation on phone #16331
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as described ✅
Is it intentional to fix this only for bookings with orders? I checked a booking without order and saw the same issue as the one this PR is fixing, I wonder if it's worth it to fix that too.
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-10.at.13.06.29.mov
Please feel free to ignore this as every booking is supposed to have an associated order in the MVP anyway.
Gonna handle that separately WOOMOB-1674 |

WOOMOB-1653
Description
Repetitive order details presentation from booking was broken on iPhone. If a booking order was presented by tapping on "View Order" in booking details, dismissed and then triggered to be presented again - the order details won't be opened the second time.
The issue is happening because
selectedOrderIDandselectedIndexPathkeep their value even when order details get dismissed on iPhone. The following logic prevented the details presentation:To resolve the above issue the
isTriggeredByUserActionattribute was added to force order details presentation if the navigation was manually triggered by the user action. Also the derails presentation logic was changed in OrdersSplitViewWrapperController - the new details VC wasn't re-created and applied in case if the new order has the same id. In that case the existing details VC was obtained and re-presented.Test Steps
TC1: Basic scenario
OrderReSelectDemo1.mov
TC2: don't dismiss the order details
Demo2.mov
RELEASE-NOTES.txtif necessary.