-
Notifications
You must be signed in to change notification settings - Fork 121
Woomob 1674 hide view order for missing orders #16335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Woomob 1674 hide view order for missing orders #16335
Conversation
|
|
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
| } | ||
|
|
||
| var isOrderValid: Bool { | ||
| return orderID != 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should use orderID > 0 instead, as a negative number should be invalid too. Also, should we rename the property to hasAssociatedOrder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d059642

WOOMOB-1674
Description
Addresses the PR comment.
0)Test Steps
302Demo
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-10.at.18.19.40.mov
RELEASE-NOTES.txtif necessary.