Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Nov 10, 2025

WOOMOB-1674

Description

Addresses the PR comment.

  • Hides "View order" option in "Payment" section if an order is absent for a booking (order id is 0)
  • Hides the "View order" option in Booking Details ellipsis menu in the same case as above.

Test Steps

  • Use CIAB site with bookings. Consider using our shared CIAB testing site.
  • Find a booking with a missing order. In our testing site that would be booking 302
  • Open booking details
  • Make sure the "Payment" section doesn't display the "View order" option
  • Tap on ellipsis menu in top right corner.
  • Make sure the action sheet doesn't contain the "View order" option
  • Regression check - find a booking with a valid order. Open booking details and make sure the "View order" option is presented both in "Payments" section and in ellipsis menu.

Demo

Simulator.Screen.Recording.-.iPhone.17.-.2025-11-10.at.18.19.40.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.7 milestone Nov 10, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Nov 10, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 10, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16335-d059642
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commitd059642
Installation URL4r6k2t6l9kgfg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@RafaelKayumov RafaelKayumov assigned adborbas and unassigned adborbas Nov 10, 2025
@itsmeichigo itsmeichigo self-assigned this Nov 11, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

}

var isOrderValid: Bool {
return orderID != 0
Copy link
Contributor

@itsmeichigo itsmeichigo Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use orderID > 0 instead, as a negative number should be invalid too. Also, should we rename the property to hasAssociatedOrder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in d059642

@RafaelKayumov RafaelKayumov merged commit ffc165a into trunk Nov 11, 2025
14 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1674-hide-view-order-for-missing-orders branch November 11, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants