-
Notifications
You must be signed in to change notification settings - Fork 121
[Bookings] Mock booking note #16334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bookings] Mock booking note #16334
Conversation
Generated by 🚫 Danger |
|
|
97bb96f to
5fd98d8
Compare
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as described 👍 I left some minor nit-picking in the comments.
|
|
||
| let bookingNotes = Section( | ||
| header: .title(Localization.bookingNotesSectionHeaderTitle.uppercased()), | ||
| footerText: "This is a private note. It'll not be shared with the customer.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this should be localized.
| .if(title != nil) { | ||
| $0.navigationTitle(title ?? "") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the if modifier seems redundant here.

Part of WOOMOB1617
Description
This PR adds the UI elements needed for the booking note row. I'll add calling the endpoint in an upcoming PR.
noteproperty to theBookingCoreData model.MultilineEditableTextRowas a reusable view shown on the booking details which when tapped opensMultilineEditableTextDetailViewTest Steps
Screenshots
RELEASE-NOTES.txtif necessary.