Skip to content

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Nov 10, 2025

Part of WOOMOB1617

Description

This PR adds the UI elements needed for the booking note row. I'll add calling the endpoint in an upcoming PR.

  • Added note property to the Booking CoreData model.
  • Update the model to version 130. Covered the change with tests.
  • Added MultilineEditableTextRow as a reusable view shown on the booking details which when tapped opens MultilineEditableTextDetailView

Test Steps

  1. Login to a CIAB store.
  2. Open Bookings tab.
  3. Open a booking detail.
  4. Scroll to the bottom.
  5. Note that the Booking Note section should say "Add note"
  6. Tap on row.
  7. Note that the editor view should be pushed. It should be empty.
  8. Type something.
  9. Note that the "Done" button should appear.
  10. Tap the Back button.
  11. Note that a confirmation dialog is shown.
  12. Dismiss the dialog.
  13. Tap Done.
  14. Note that the Booking Note section should display whatever you have typed.

Screenshots

Simulator Screen Recording - iPhone 17 Pro - 2025-11-10 at 14 57 02


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@adborbas adborbas added this to the 23.7 milestone Nov 10, 2025
@adborbas adborbas added the type: task An internally driven task. label Nov 10, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 10, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 10, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16334-a7e4da2
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commita7e4da2
Installation URL1mpajs6fi4qk8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas changed the title Adborbas/woomob 1617 Mock booking notes Nov 10, 2025
@adborbas adborbas changed the title Mock booking notes [Bookings] Mock booking note Nov 10, 2025
@adborbas adborbas marked this pull request as ready for review November 10, 2025 13:52
@adborbas adborbas force-pushed the adborbas/woomob-1617 branch from 97bb96f to 5fd98d8 Compare November 10, 2025 13:52
@itsmeichigo itsmeichigo self-assigned this Nov 11, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as described 👍 I left some minor nit-picking in the comments.


let bookingNotes = Section(
header: .title(Localization.bookingNotesSectionHeaderTitle.uppercased()),
footerText: "This is a private note. It'll not be shared with the customer.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this should be localized.

Comment on lines 26 to 28
.if(title != nil) {
$0.navigationTitle(title ?? "")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the if modifier seems redundant here.

@adborbas adborbas enabled auto-merge November 11, 2025 07:24
@adborbas adborbas merged commit 92918d7 into trunk Nov 11, 2025
14 checks passed
@adborbas adborbas deleted the adborbas/woomob-1617 branch November 11, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants