Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Nov 12, 2025

WOOMOB-1652

Description

Fixes the repeating requests. The following code caused duplicated data sync:

  • The task in BookingDetailsView body
.task {
    await viewModel.syncData()
}
  • Sync triggering in BookingDetailsView.init
init(_ viewModel: BookingDetailsViewModel) {
    self.viewModel = viewModel

    /// Trigger remote data sync
    Task {
        await viewModel.syncData()
    }
}

Test Steps

  • Use CIAB site with bookings
  • Use Proxyman or any other networking debugging tool
  • Navigate to bookings tab
  • Clear the Proxyman log for convenience
  • Select a booking in bookings list
  • Make sure Proxyman displays 3 requests per booking:
    • /wc-bookings/v2/bookings/315&_method=get - booking details
    • wc/v3/orders&_method=get - booking order details
    • /wc-bookings/v2/resources/team-members/{member_id}&_method=get - team member details

Demo

2025-11-12.13.11.20.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.7 milestone Nov 12, 2025
@RafaelKayumov RafaelKayumov added type: bug A confirmed bug. Bug labels Nov 12, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 23.7. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16348-02fdc19
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commit02fdc19
Installation URL1dem3mqmm4d6g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Nov 13, 2025
@RafaelKayumov RafaelKayumov merged commit 01c729e into trunk Nov 13, 2025
22 of 24 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1652-fix-repeating-requests-on-booking-details-screen branch November 13, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants