Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Nov 24, 2025

Description

After the POS modularization, we have lost the localized strings in POS due to the module path being missing from one of the code freeze steps, which grabs the strings from the iOS codebase and sends them to GlotPress.

Since POS is currently set mostly for en language users, we decided to take the path of re-adding the path in 22.7 and restoring localized strings for next release (23.8) Ref: p1763729754474429?thread_ts=1763708437.689109&cid=CC7L49W13-slack-CC7L49W13

Changes:

  • Add Modules/Sources/PointOfSale/ path to generate_strings_file_for_glotpress lane
  • Restored POS string-keys in en.lproj/Localizable.strings

Test Steps

  • Copypaste one or several of the restored pos. or pointOfSale. key-values from en.lproj/Localizable.strings to a different language (i.e: es.lproj/Localizable.strings. Example:
/* Hint to add products to the Cart when this is empty. */
"pos.cartView.addItemsToCartOrScanHint" = "Tap on a product to \n add it to the cart, or ";
  • Change it's value to something else
  • Run the app in that language and observe the new value is used in the app

When generating strings for Glotpress from the iOS strings, the path to the POS module is missing
@iamgabrielma iamgabrielma added type: bug A confirmed bug. type: task An internally driven task. labels Nov 24, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 24, 2025

2 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 23.7 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added this to the 23.7 ❄️ milestone Nov 24, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review November 24, 2025 05:14
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16384-92e473b
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commit92e473b
Installation URL3bv7j66urpqtg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma merged commit eca88dc into release/23.7 Nov 24, 2025
25 checks passed
@iamgabrielma iamgabrielma deleted the task/restore-POS-localization branch November 24, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A confirmed bug. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants