Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Nov 24, 2025

Part of WOOMOB-1755

Description

We got reports about some devices still get push notifications even after logging out. While testing, I notice that very often I don't see 📱 Successfully unregistered from WordPress.com Push Notifications! in my logs after logging out.

This PR adds updates to ensure that push notifications are unregistered completely upon logout. The solution is to keep a strong reference of the authenticated state until unregisteration is finished.

Test Steps

  • Build and run the app on a device.
  • Log in to a test store with a WPCom account if you haven't already.
  • Log out of the app.
  • Tap Log in > Help > View application Log > Current.
  • Scroll to the bottom of the log.
  • Confirm that you see 📱 Successfully unregistered from WordPress.com Push Notifications! near the bottom.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.8 milestone Nov 24, 2025
@itsmeichigo itsmeichigo added the type: enhancement A request for an enhancement. label Nov 24, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 24, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16386-5f51a1d
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commit5f51a1d
Installation URL508k4h2gqa6kg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review November 24, 2025 11:48
@RafaelKayumov RafaelKayumov self-assigned this Nov 24, 2025
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

Снимок экрана 2025—11—24 в 17 56 26

@itsmeichigo itsmeichigo merged commit 16d631d into trunk Nov 25, 2025
16 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1755-push-notification-tokens-are-not-unregistered-on-logout branch November 25, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants