[Local catalog] Don’t show unsupported products in search results

[joshheald]

Description

This PR prevents trashed/draft/pending products from being shown in search results.

Test Steps

• Launch the app and open POS
• In WP-Admin, trash a product (or make it draft/pending)
• Pull to refresh the item list to do an incremental sync
• Search for the trashed product – observe that it's not shown

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	pr16389-737641a
	Version	23.7
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	737641a
	Installation URL	2374rehn7b8b0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[iamgabrielma]

Products that have been searched before still will show under "popular searches" despite being unsupported after the action to change their status, not sure if should be part of the scope of this PR, handled separately, or not handled at all:

1. search for a product
2. trash it
3. perform partial sync
4. open the search, product will display there, then immediately be removed as soon as we start to type something

Cached omelette	Trashed omelette

Otherwise LGTM!

[joshheald]

Products that have been searched before still will show under "popular searches" despite being unsupported after the action to change their status, not sure if should be part of the scope of this PR, handled separately, or not handled at all:

Otherwise LGTM!

Good catch. The popular products aren't fed from the local catalog, so this is an existing issue. We could refresh them at the same time as we do an incremental sync, at least from PTR/purchase. I'll see if it's straightforward and do it here if it is... but I don't think it's a must have.

Thanks for the review

[dangermattic]

	1 Warning
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

[joshheald]

Products that have been searched before still will show under "popular searches" despite being unsupported after the action to change their status, not sure if should be part of the scope of this PR, handled separately, or not handled at all:

I'll see if it's straightforward and do it here if it is... but I don't think it's a must have.

Done in 737641a – it's not the neatest thing in the world, but on the plus side it make the fix work with the non-local catalog approach as well, and we have other specific controller calls in the item list (e.g. coupon creation.)

I suspect we'll eventually replace the popular products with something from the local catalog too