Skip to content

Conversation

@joshheald
Copy link
Contributor

Description

This PR updates the unit tests to avoid creating BackgroundTaskScheduleTests.swift.plist on every test run

Test Steps

  • Run unit tests
  • Ensure BackgroundTaskScheduleTests.swift.plist is not in your working copy when they complete

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added this to the 23.8 milestone Nov 26, 2025
@joshheald joshheald added type: task An internally driven task. category: unit tests Related to unit testing. feature: core Core work. See "category: tooling" and "category: architecture" labels Nov 26, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 26, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@joshheald joshheald marked this pull request as ready for review November 26, 2025 09:44
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 26, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16404-fed061c
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commitfed061c
Installation URL2gn1gmvvd3rh8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma self-assigned this Nov 27, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@joshheald joshheald merged commit 745c03f into trunk Nov 27, 2025
13 checks passed
@joshheald joshheald deleted the task/woomob-1804-fix-background-scheduler-tests-creating-a-plist branch November 27, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: unit tests Related to unit testing. feature: core Core work. See "category: tooling" and "category: architecture" type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants