[Woo POS][App Listings] ASC promo screenshots #16405
Draft
+61
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
iamgabrielma
added
the
generate screenshots
Collaborator
|
|
Despite tests passing, the contents of the pos-payment screenshot was incorrect, as lands on the failure case for `checkOrderIsStillEligibleForPayment` when attempting to retrieve the order details, hence showing a “Error: unable to process payment. we could not fetch the latest order details” rather than the payment view. Despite passing the CPP mock in the POSTabCoordinator, we were never setting it in the test as a launch argument.
Since we run the notification screenshot the last one due to the UI test flow, when we run the create_promo lane then screenshot descriptions are miss-aligned with what they show which fails the job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1644
Do not merge until we have localizations back into POS which should happen after 23.7 freeze. Once this is set, we can re-run the
create_promolane to render the localized screens for all locales.Description
Changes
Test Steps
WooCommerceScreenshots.testScreenshots()both in iPad and iPhone as your run destination, they should pass (some UI tests are a bit flaky, but on a second run they should normally pass correctly)Screenshots
RELEASE-NOTES.txtif necessary.