Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

WOOMOB-1813

Description

This PR duplicates the #16411 and targets the hotfix branch.

The PR addresses the issue where a user couldn't see TPP and card reader options in non-CIAB site. We suspect that the culprit is a site reading from local store. Since we couldn't reproduce the issue - we're adding this as a safety measure. Additionally we're adding error logging to see if the suspected issue indeed happens.

  • Adds a fallback to currentSite as a safety measure for a case where a site can't be fetched by id from storage.
  • Wraps CIAB site assessments behind a feature flag
  • Proceeds the order eligibility checks in case if site wasn't obtained
  • Adds .error logging for the above case
  • Adds .error logging for the case where even a currentSite couldn't be obtained.

Test Steps

  • Use a CIAB site with unpaid orders
  • Navigate to an order that's not yet paid and eligible for a card payment.
  • Tap on "Collect Payment" CTA
  • Make sure the "Card Reader" option is not visible
  • Switch to non-CIAB site
  • Make sure the "Card Reader" option is displayed for eligible orders in non-CIAB sites.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.6.1 milestone Nov 27, 2025
@RafaelKayumov RafaelKayumov added type: bug A confirmed bug. Bug labels Nov 27, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 27, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.6.1. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@RafaelKayumov RafaelKayumov marked this pull request as ready for review November 27, 2025 15:19
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16413-8ebbd2e
Version23.6.1
Bundle IDcom.automattic.alpha.woocommerce
Commit8ebbd2e
Installation URL00ansska95r38
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks for the update as well.

@RafaelKayumov RafaelKayumov merged commit 5e3d755 into release/23.6.1 Nov 27, 2025
24 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1813-fix-missing-card-payment-options-hotfix branch November 27, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants