Skip to content

[release/23.7] Revert notify listeners #16425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/23.7
Choose a base branch
from
+0 −3
Open

[release/23.7] Revert notify listeners #16425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54c6621
Revert "Notify listeners of changes when updating predicate and sort …
RafaelKayumov Dec 2, 2025
b4c9f1f
Revert release notes for listeners notifying mention
RafaelKayumov Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Modules/Sources/Yosemite/Tools/ResultsController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,15 +234,13 @@ public class GenericResultsController<T: ResultsControllerMutableType, Output> {
private func refreshFetchedObjects(predicate: NSPredicate?) {
controller.fetchRequest.predicate = predicate
try? controller.performFetch()
onDidChangeContent?()
}

/// Refreshes all of the Fetched Objects, so that the new sort descriptors are applied.
///
private func refreshFetchedObjects(sortDescriptors: [NSSortDescriptor]?) {
controller.fetchRequest.sortDescriptors = sortDescriptors
try? controller.performFetch()
onDidChangeContent?()
}

/// Initializes the FetchedResultsController
Expand Down
1 change: 0 additions & 1 deletion RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
- [*] Fix product variation selection for order creation [https://github.com/woocommerce/woocommerce-ios/pull/16317]
- [internal] Hide non-CIAB product types from filters [https://github.com/woocommerce/woocommerce-ios/pull/16354]
- [Internal] Fix warning when displaying offline banner on My Store [https://github.com/woocommerce/woocommerce-ios/pull/16347]
- [Internal] Notify listeners immediately after updating predicates or sort descriptors for results controllers. [https://github.com/woocommerce/woocommerce-ios/pull/16350]

23.6
-----
Expand Down
Loading