Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Dec 17, 2025

Description

We have found ourselves a few times in iOS with lack of data when trying to check WooCommerce versions from the track events dashboard, for example, recently when deciding if would be good enough to increase the threshold of a feature from 9.6 to 9.7, since we could only rely on Android data and guess iOS user base distribution would be similar

This PR mimics Android's approach to pass the WooCommerce version as default property along track events.

For this we retrieve, store in memory, and pass the woo version through the cached_woo_core_version property (for consistency with Android naming) to all track events, following the same pattern as others like isWpcomStore.

Test Steps

  • With 2 different woocommerce stores, on different woocommerce versions (or test with the same store by updating the version)
  • Run the app, note in the console how cached_woo_core_version tracks the woo version
  • In menu > change store, note the version tracked is correct.

Store 1:

🔵 Tracked ... cached_woo_core_version: 10.3.6 ... blog_id: 250994203]

Store 2:

🔵 Tracked ... cached_woo_core_version: 10.4.2 ... blog_id: 215063064]

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 17, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16464-8b243ad
Version23.8
Bundle IDcom.automattic.alpha.woocommerce
Commit8b243ad
Installation URL60v2tgfsf5tbg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma marked this pull request as ready for review December 18, 2025 02:22
@iamgabrielma iamgabrielma added type: enhancement A request for an enhancement. type: task An internally driven task. labels Dec 18, 2025
@iamgabrielma iamgabrielma added this to the 23.9 milestone Dec 18, 2025
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and helpful, thanks for adding it.

FYI I struggled to test the caching – changing woo versions caused lots of other problems on my test sites and I'm a bit short of time to go deep on it. If you've seen it working, I'm sure it's fine, and the risk is low anyway.

# Conflicts:
#	WooCommerce/Classes/Analytics/WooAnalytics.swift
the analytics key for cachedWooCommerceVersionKey was removed on c5bbc3e when resolving a merge conflict.
@iamgabrielma iamgabrielma merged commit e75e5bd into trunk Dec 24, 2025
13 checks passed
@iamgabrielma iamgabrielma deleted the task/HACK-add-woo-cached-version-to-tracks branch December 24, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A request for an enhancement. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants