Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Dec 18, 2025

Description

This is a speculative fix for a rare crash which I can't reproduce, and an important update to keep our Stripe dependency current.

There's a v5, but it has breaking changes, so we'll tackle that separately.

Test Steps

Test payments with a card reader and tap to pay.
I've tested using Chipper, M2, WisePad 3, and TTP.

I found an unrelated issue where Interac refunds in Canada seem to fail. This is pre-existing and I'll work on it in another ticket.

Note that I found there was a strange issue where Tap to Pay wasn't offered. This was because the incorrect enum raw value was used for DeviceType when detectign support, resulting in the device being marked as not supporting tap to pay because it had looked for an internet reader instead, and got an error from Stripe Terminal. A clean build fixed this, so it seems to be related to leftover build artefacts.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added this to the 23.9 milestone Dec 18, 2025
@joshheald joshheald added type: crash The worst kind of bug. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Dec 18, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 18, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16467-854c7a6
Version23.8
Bundle IDcom.automattic.alpha.woocommerce
Commit854c7a6
Installation URL1i9ctn3vg76lg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald marked this pull request as ready for review December 18, 2025 11:51
@joshheald
Copy link
Contributor Author

@iamgabrielma Just a bump on this one in case you missed it...

@iamgabrielma
Copy link
Contributor

@iamgabrielma Just a bump on this one in case you missed it...

Thanks! I did miss it 🙇

@iamgabrielma iamgabrielma self-assigned this Dec 24, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested in US store using M2 reader, both card and TTP, using iPhone 14 on iOS 18.7.2

I've logged as well a task in linear to plan the bump to 5.0

@iamgabrielma iamgabrielma merged commit e8bddf9 into trunk Dec 24, 2025
12 of 13 checks passed
@iamgabrielma iamgabrielma deleted the woomob-1893-crash-in-stripe-when-logging branch December 24, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: crash The worst kind of bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants