Skip to content

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Dec 19, 2025

Fixes WOOMOB-1864

Description

Fixes the linked issue by constraining the moreDetailsContainerView to the keyboardLayoutGuide.topAnchor instead of setting the contentInset via KeyboardFrameObserver.

Test Steps

  1. Log in to any store that has orders.
  2. Tap a product in the "Top performers" card.
  3. Tap in the title to edit.
  4. Note that when the keyboard opens, the title is still visible.

Screenshots

Before After
Simulator Screen Recording - iPhone 17 Pro - 2025-12-19 at 09 01 28 Simulator Screen Recording - iPhone 17 Pro - 2025-12-19 at 10 02 43
Simulator Screen Recording - iPad Pro 11-inch (M4) - 2025-12-19 at 09 59 52 Simulator Screen Recording - iPad Pro 11-inch (M4) - 2025-12-19 at 09 57 46

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@adborbas adborbas added this to the 24.0 milestone Dec 19, 2025
@adborbas adborbas added the type: bug A confirmed bug. label Dec 19, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 19, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16470-ca7a9b0
Version23.8
Bundle IDcom.automattic.alpha.woocommerce
Commitca7a9b0
Installation URL692jtka94ejgg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas changed the title Conditionally move keyboard Fix keyboard scrolling product title Dec 19, 2025
@adborbas adborbas marked this pull request as ready for review December 19, 2025 10:57
@adborbas adborbas enabled auto-merge December 19, 2025 13:57
@RafaelKayumov RafaelKayumov self-assigned this Dec 25, 2025
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on iPad, iPhone 17 and iPhone SE simulators. Tried increasing the accessibility font to make it hard for title field to fit with opened keyboard. Worked well.

Simulator.Screen.Recording.-.iPhone.SE.iOS.26.-.2025-12-25.at.16.35.35.mov

I wonder if enabling the automatic table view inset adjustment would also solve the issue. Currently it's disabled tableView.contentInsetAdjustmentBehavior = .never

But since it works - I'm ok. LGTM

@adborbas adborbas merged commit 9a6fe15 into trunk Dec 25, 2025
13 checks passed
@adborbas adborbas deleted the adborbas/woomob-1864-automattically-scrolling-down-when-editing-product-title branch December 25, 2025 13:37
@RafaelKayumov RafaelKayumov modified the milestones: 24.0, 23.9 Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants