-
Notifications
You must be signed in to change notification settings - Fork 121
Bump deployment target to 15.0 #7851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can test the changes from this Pull Request by:
|
|
As I was working on some other branch I noticed that I might not have updated every single target to 15.0. Turning this to draft again while I double check |
|
Nice job @koke! It builds and test cases run fine. Unfortunately, I see a bunch of "deprecated in iOS 15" warnings e.g Shall we get rid of those in this PR, or create an issue to address them later? |
|
I put up an internal discussion in p91TBi-9WX-p2, although it makes sense to also create the issues here. I don't think we should block this PR on those, since they might require a decent amount of effort and we might want to prioritize that separately. |
Ah great, I approved it then :) |
Generated by 🚫 dangerJS |
0e449de to
9953b7f
Compare
9953b7f to
9b4387f
Compare
Closes: #7850
Description
Updates the minimum deployment version to 15.0 on all the project's targets. Doing this shows 40+ new deprecation warnings. I've addressed a couple of them but others will need some extra work:
currentKeyWindow, which was deprecated in iOS 13. We'll need to eventually invest some time in adapting the existing hacks to window scenes, or removing them altogether.Also noted ☝🏽 in p91TBi-9WX-p2
Testing instructions
CI tests should pass.
For the animation change:
For the UTTType changes:
RELEASE-NOTES.txtif necessary.