Skip to content

Conversation

@koke
Copy link
Member

@koke koke commented Oct 13, 2022

Closes: #7850

Description

Updates the minimum deployment version to 15.0 on all the project's targets. Doing this shows 40+ new deprecation warnings. I've addressed a couple of them but others will need some extra work:

  • 'animation' was deprecated in iOS 15.0: Use withAnimation or animation(_:value:) instead.
  • 'kUTTypeImage'/'kUTTypeGIF' was deprecated in iOS 15.0
  • 'contentEdgeInsets'/'imageEdgeInsets'/'titleEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration. There's a whole new way of styling buttons on iOS 15, which would require more than a quick fix
  • 'windows' was deprecated in iOS 15.0: Use UIWindowScene.windows on a relevant window scene instead. This is mostly used on a reimplementation of currentKeyWindow, which was deprecated in iOS 13. We'll need to eventually invest some time in adapting the existing hacks to window scenes, or removing them altogether.

Also noted ☝🏽 in p91TBi-9WX-p2

Testing instructions

CI tests should pass.

For the animation change:

  1. Go to Settings > Help & Support > View Application Log
  2. The button on the bottom-right corner should scroll to the bottom of the log with an animation

For the UTTType changes:

  1. Save a GIF to your camera roll
  2. Go to products
  3. Add a new product
  4. Add an image, select "Choose from device"
  5. Select the "Recents" album
  6. The GIF should have a "GIF" badge.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@koke koke added type: task An internally driven task. feature: in-app purchases Related to In-app purchases and subscriptions labels Oct 13, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 13, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7851-9b4387f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@koke koke added this to the 10.8 milestone Oct 13, 2022
@koke koke requested a review from toupper October 13, 2022 13:34
@koke koke marked this pull request as ready for review October 13, 2022 13:34
@koke koke marked this pull request as draft October 14, 2022 08:44
@koke
Copy link
Member Author

koke commented Oct 14, 2022

As I was working on some other branch I noticed that I might not have updated every single target to 15.0. Turning this to draft again while I double check

@koke koke modified the milestones: 10.8, 10.9 Oct 14, 2022
@koke koke marked this pull request as ready for review October 14, 2022 11:16
@koke koke mentioned this pull request Oct 17, 2022
1 task
@koke koke requested a review from a team October 18, 2022 10:47
@toupper toupper self-assigned this Oct 18, 2022
@toupper
Copy link
Contributor

toupper commented Oct 18, 2022

Nice job @koke! It builds and test cases run fine. Unfortunately, I see a bunch of "deprecated in iOS 15" warnings e.g 'contentEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration

Shall we get rid of those in this PR, or create an issue to address them later?

@koke
Copy link
Member Author

koke commented Oct 18, 2022

I put up an internal discussion in p91TBi-9WX-p2, although it makes sense to also create the issues here. I don't think we should block this PR on those, since they might require a decent amount of effort and we might want to prioritize that separately.

@toupper
Copy link
Contributor

toupper commented Oct 18, 2022

I put up an internal discussion in p91TBi-9WX-p2, although it makes sense to also create the issues here. I don't think we should block this PR on those, since they might require a decent amount of effort and we might want to prioritize that separately.

Ah great, I approved it then :)

@koke
Copy link
Member Author

koke commented Oct 19, 2022

Created those issues in #7881 and #7882

@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@koke koke force-pushed the issue/7850-ios-15 branch from 0e449de to 9953b7f Compare October 19, 2022 09:33
@koke koke force-pushed the issue/7850-ios-15 branch from 9953b7f to 9b4387f Compare October 19, 2022 09:34
@koke koke enabled auto-merge October 19, 2022 09:35
@koke koke merged commit 3f19009 into trunk Oct 19, 2022
@koke koke deleted the issue/7850-ios-15 branch October 19, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: in-app purchases Related to In-app purchases and subscriptions type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump deployment target to iOS 15

4 participants