-
Notifications
You must be signed in to change notification settings - Fork 121
Widgets Configuration: Add time interval setting #7873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ealeksandrov
merged 6 commits into
issue/7863-widgets-configuration
from
issue/7863-widgets-configuration-time-interval
Oct 20, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
76eee5d
Update StatsTimeRange
ealeksandrov b166b45
Update visitors API call to use custom time range
ealeksandrov 042c7cb
Update StatsTimeRange
ealeksandrov abf9438
Update stats API call to use custom time range
ealeksandrov 6afdcd5
Show correct period title in widget
ealeksandrov dbb6279
Remove hardcoded mention of today time interval
ealeksandrov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think all of these properties should be shared in a commonplace with the main stats code?
Since we are going to update the analytics dashboard soon, there is a chance that these go outdated.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about moving
StatsTimeRangeV4toWooFoundation, but it importsNetworkingmodels. Do you think it's ok to allow WooFoundation depend on Networking? Or can we move all related models to WF and make Networking import it?Original StatsTimeRangeV4 currently lives in Yosemite. I copy-pasted the code to prevent the import of
Yosemite+Storage(+Networkingbut it's already imported to widgets target).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probs not. Maybe we can move that to an extension helper that is imported in both targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be
WooFoundation? I don't like idea of creating another library for a few models.StatsTimeRangeV4from Yosemite to WFStatGranularityfrom Networking to WFStatsTimeRangeand useStatsTimeRangeV4in widgets from WFThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That also work, may involve more work tho!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'll merge current implementation into the feature branch and we can experiment with dependencies later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️ What are the chances of this happening? What is the risk? How many times is this duplicated?
Maybe we can also use the Rule of three as a guideline.
Another library is also fine to me, assuming the cost is smaller compared to trying to place it in
WooFoundation.