Skip to content

Conversation

@koke
Copy link
Member

@koke koke commented Oct 21, 2022

Part of #7836

Description

In #7883, I forgot I had hardcoded siteID=0 for the IAP debug view. This PR uses the active store ID instead so the API doesn't fail.

Testing instructions

  1. Set a breakpoint in InAppPurchasesRemote.createOrder
  2. Go to Hub Menu > IAP Debug
  3. Purchase a product
  4. Once the debugger stops, ensure the passed siteID isn't 0

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@koke koke added type: bug A confirmed bug. feature: in-app purchases Related to In-app purchases and subscriptions labels Oct 21, 2022
@koke koke added this to the 10.9 milestone Oct 21, 2022
@koke koke requested a review from toupper October 21, 2022 10:36
@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7893-b5f767d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@toupper
Copy link
Contributor

toupper commented Oct 21, 2022

Tested, siteID isn't 0 when creating an order 🎉 I had to hardcode com.woocommerce as bundle id to make it work though, otherwise backend did not allow to request products. :shipit:

@koke koke merged commit 9cb0d76 into trunk Oct 21, 2022
@koke koke deleted the issue/7836-iap-integration-fixes branch October 21, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: in-app purchases Related to In-app purchases and subscriptions type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants