Skip to content

Product Preview: Add WebView authentication tools #7961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 31, 2022
Merged

Product Preview: Add WebView authentication tools #7961

merged 6 commits into from
Oct 31, 2022

Conversation

@ealeksandrov
Copy link
Contributor

@ealeksandrov ealeksandrov commented Oct 27, 2022

Part of #7911

Description

This PR migrates 3 classes over from WP-iOS app:

  • CookieJar (no changes)
  • AuthenticationService (crash logging update for WC compatibility)
  • RequestAuthenticator (significant update removing unused flows and adapting to WC.Site object)

with existing unit tests.

Testing

Check CI status, these tools are not yet used in user-reachable flows in app.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ealeksandrov ealeksandrov added the feature: product details Related to adding or editing products, including Product Settings. label Oct 27, 2022
@ealeksandrov ealeksandrov added this to the 11.0 milestone Oct 27, 2022
@ealeksandrov ealeksandrov mentioned this pull request Oct 27, 2022
Closed
5 tasks
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 27, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7961-879f817 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Ecarrion
Ecarrion approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ealeksandrov ealeksandrov modified the milestones: 11.0, 11.1 Oct 28, 2022
This was referenced Oct 28, 2022
Merged
Closed
Base automatically changed from issue/7944-product-preview-flow to trunk October 31, 2022 16:16
@ealeksandrov ealeksandrov merged commit 8d7eafe into trunk Oct 31, 2022
@ealeksandrov ealeksandrov deleted the issue/7911-webview-authentication branch October 31, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachelmcr rachelmcr Awaiting requested review from rachelmcr

1 more reviewer

@Ecarrion Ecarrion Ecarrion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: product details Related to adding or editing products, including Product Settings.

Projects

None yet

Milestone

11.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ealeksandrov @wpmobilebot @Ecarrion