-
Notifications
You must be signed in to change notification settings - Fork 121
Products Onboarding: Integrate Template Endpoint #7992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can test the changes from this Pull Request by:
|
rachelmcr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great for most cases! I just ran into one problem where I'm blocked when the template request fails (details in comment).
| switch result { | ||
| case .success(let product): | ||
| // Dismiss the loader and present the product. | ||
| inProgressViewController.dismiss(animated: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! fixed in 5269f3e
error-demo.mov
rachelmcr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀

Closes: #7920
Why
This PR makes sure that after selecting a product template the app:
Note: Refining on the product form for the template(auto-draft) product will come in a next PR #7949
How
Demo
template.mov
normal.mov
Testing
Note: Updating the product and making sure it all works & looks correctly will come in a later PR
RELEASE-NOTES.txtif necessary.