Skip to content

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Nov 4, 2022

Part of #7891

Description

To meet the timeline (code freeze today), I deferred the unit tests until after the feature was complete. Debounce duration was DI'ed with 0 in the unit tests so as not to lengthen the testing time.

Testing instructions

CI should be sufficient, but feel free to test the account creation form to make sure the debounce still works.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added the type: technical debt Represents or solves tech debt of the project. label Nov 4, 2022
@jaclync jaclync added this to the 11.1 milestone Nov 4, 2022
@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8024-5c3b6ff on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this Nov 4, 2022
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

The unit tests are running successfully locally. To fix CI, I have restarted the buildkite unit tests script. 🤞

@jaclync jaclync merged commit 99f03e7 into trunk Nov 4, 2022
@jaclync jaclync deleted the td/7891-AccountCreationFormViewModel-tests branch November 4, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants