Skip to content

Fix order notification deeplink #8042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Fix order notification deeplink #8042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
137edcc
Add MainActor annotation
ealeksandrov Nov 4, 2022
aeb02b5
Remove condition in notification deeplink
ealeksandrov Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WooCommerce/Classes/Notifications/PushNotificationsManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,7 @@ private extension PushNotificationsManager {
/// Handles a remote notification while the app is inactive.
///
/// - Parameter notification: Push notification content from a remote notification.
@MainActor
func handleInactiveRemoteNotification(notification: PushNotification) async {
guard applicationState == .inactive else {
return
Expand Down
6 changes: 2 additions & 4 deletions WooCommerce/Classes/ViewRelated/MainTabBarController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,8 @@ extension MainTabBarController {
}
let siteID = Int64(note.meta.identifier(forKey: .site) ?? Int.min)

switchToStore(with: siteID, onCompletion: { siteChanged in
if siteChanged {
presentNotificationDetails(for: note)
}
switchToStore(with: siteID, onCompletion: { _ in
presentNotificationDetails(for: note)
})
}
ServiceLocator.stores.dispatch(action)
Expand Down