Skip to content

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Nov 7, 2022

Closes: #7793

Description

Since the design has changed in favor of native account creation (signup) in #7891, I deleted the unused wpcomSignup feature flag and reverted the changes in #7794. Everything should work as before because the feature is disabled.

Testing instructions

You can do a confidence check by:

  • Launch the app
  • Log out and skip onboarding if needed
  • Tap either login button
  • When entering the WPCOM email, enter an email that isn't associated with a WPCOM account --> the login email error screen should be shown instead of continuing with the account creation flow in the WPAuthenticator library

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added the type: technical debt Represents or solves tech debt of the project. label Nov 7, 2022
@jaclync jaclync added this to the 11.2 milestone Nov 7, 2022
@itsmeichigo itsmeichigo self-assigned this Nov 7, 2022
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8044-d399c0f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@jaclync jaclync merged commit 7f3352f into trunk Nov 8, 2022
@jaclync jaclync deleted the td/7793-remove-unused-signup-feature-flag branch November 8, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WordPress.com account creation

4 participants