-
Notifications
You must be signed in to change notification settings - Fork 121
Products Onboarding: Add support for using frame_nonce in product previews
#8052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 dangerJS |
You can test the changes from this Pull Request by:
|
pachlava
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was automatically added as a reviewer as a part of "mobile-ui-testing-squad" because the PR changes a UI tests related file: namely, adds (78be945) frame_nonce param to rest_v11_me_sites.json.
I can see that all UI tests started to pass after that, so it's good to go from our side. Kudos for doing this @rachelmcr! 🙌
(I did not do a code review of the rest of the files).
|
Just a note that I'm waiting to merge this PR until we've decided whether to move forward with storing |
ealeksandrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As we discussed in post linked above, I consider it safe to merge ![]()
Thanks for taking another look around frame-nonce logic in Jetpack!
Part of: #8046
Description
This PR includes the support @ealeksandrov added for a site's
frame_nonceoption in the Networking, Yosemite, and Storage layers:frame_noncesite option when the user's sites are requested from theme/sitesendpoint.frameNonceattribute on theSiteentity in Core Data (adding a new Core Data model).Testing
The
frameNonceattribute is not yet used in the app; confirm all unit tests pass.Submitter Checklist
Update release notes:
RELEASE-NOTES.txtif necessary.