Skip to content

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Nov 9, 2022

Closes: #8063

Description

Currently, we don't have a specific tracking event to track the XMLRPC-related errors. This PR adds a new tracking event to track these failures.

This PR is for testing the changes made to the Authenticator library.

Testing instructions

Prerequisites

  • Disable simplified login
    As we are running AB tests to be able to sign in using a store address you may have to hardcode and disable simplified login by changing line no 58 in AuthenticationManager file.
let isSimplifiedLoginI1Enabled = false//ABTest.abTestLoginWithWPComOnly.variation != .control

Steps to test

  1. Install and launch the app.
  2. Skip the prologue and tap on the "Enter Your Store Address" button.
  3. Enter the JN site address and tap Continue.
  4. After the request finishes, you will see an error screen. (It shows not a WP site error which will be fixed when we remove XMLRPC checks)
  5. Check logs and ensure that the following event is tracked.
Tracked unified_login_failure, properties: [AnyHashable("failure"): "login_failed_to_guess_xmlrpc_url", AnyHashable("source"): "default", AnyHashable("flow"): "login_site_address", AnyHashable("step"): "start"]
  1. There should also be another unified_login_failure event with the actual error message. Please note that the error message will be different for various type of errors.
Tracked unified_login_failure, properties: [AnyHashable("failure"): "Couldn\'t connect to the WordPress site. There is no valid WordPress site at this address. Check the site address (URL) you entered.", AnyHashable("source"): "default", AnyHashable("flow"): "login_site_address", AnyHashable("step"): "start"]

Screenshots

NA


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@selanthiraiyan selanthiraiyan added type: task An internally driven task. feature: login Related to any part of the log in or sign in flow, or authentication. labels Nov 9, 2022
@selanthiraiyan selanthiraiyan added this to the 11.2 milestone Nov 9, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 9, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 9, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8064-a54e5dc on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@itsmeichigo itsmeichigo self-assigned this Nov 9, 2022
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@selanthiraiyan selanthiraiyan merged commit 8bb50fe into trunk Nov 9, 2022
@selanthiraiyan selanthiraiyan deleted the feat/8063-track-xmlrpc-error branch November 9, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new event to track XMLRPC error

4 participants