Skip to content

Products Onboarding: Adds a templateEligible property to productListAddProductTapped event #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Products Onboarding: Adds a templateEligible property to productListAddProductTapped event #8072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions WooCommerce/Classes/Analytics/WooAnalyticsEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1722,6 +1722,7 @@ extension WooAnalyticsEvent {
enum ProductsOnboarding {
enum Keys: String {
case type
case templateEligible = "template_eligible"
}

enum CreationType: String {
Expand All @@ -1746,5 +1747,9 @@ extension WooAnalyticsEvent {
static func productCreationTypeSelected(type: CreationType) -> WooAnalyticsEvent {
WooAnalyticsEvent(statName: .addProductCreationTypeSelected, properties: [Keys.type.rawValue: type.rawValue])
}

static func productListAddProductButtonTapped(templateEligible: Bool) -> WooAnalyticsEvent {
WooAnalyticsEvent(statName: .productListAddProductTapped, properties: [Keys.templateEligible.rawValue: templateEligible])
}
}
}
13 changes: 11 additions & 2 deletions WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ final class AddProductCoordinator: Coordinator {
}

func start() {

ServiceLocator.analytics.track(event: .ProductsOnboarding.productListAddProductButtonTapped(templateEligible: isTemplateOptionsEligible()))

if shouldPresentProductCreationBottomSheet() {
presentProductCreationTypeBottomSheet()
} else {
Expand All @@ -77,10 +80,16 @@ final class AddProductCoordinator: Coordinator {
private extension AddProductCoordinator {

/// Defines if the product creation bottom sheet should be presented.
/// Currently returns `true` when the feature is enabled and the number of products is fewer than 3.
/// Currently returns `true` when the feature is enabled and the store is eligible for displaying template options.
///
func shouldPresentProductCreationBottomSheet() -> Bool {
isProductCreationTypeEnabled && productsResultsController.numberOfObjects < 3
isProductCreationTypeEnabled && isTemplateOptionsEligible()
}

/// Returns `true` when the number of products is fewer than 3.
///
func isTemplateOptionsEligible() -> Bool {
productsResultsController.numberOfObjects < 3
}

/// Presents a bottom sheet for users to choose if they want a create a product manually or via a template.
Expand Down
2 changes: 0 additions & 2 deletions WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,6 @@ private extension ProductsViewController {
return
}

ServiceLocator.analytics.track(.productListAddProductTapped)

let coordinatingController: AddProductCoordinator
if let sourceBarButtonItem = sourceBarButtonItem {
coordinatingController = AddProductCoordinator(siteID: siteID,
Expand Down