Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Yosemite/Yosemite/Tools/Media/MediaAssetExporter.swift
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ final class MediaAssetExporter: MediaExporter {
if let resource = resources.first {
resourceAvailableLocally = true
filename = resource.originalFilename
if UTTypeEqual(resource.uniformTypeIdentifier as CFString, kUTTypeGIF) {
if resource.uniformTypeIdentifier == UTType.gif.identifier {
// Handles GIF export differently from images.
exportGIF(forAsset: asset, resource: resource, onCompletion: onCompletion)
return
Expand Down Expand Up @@ -112,7 +112,7 @@ private extension MediaAssetExporter {
return nil
}
guard allowableFileExtensions.contains(fileExtensionForType) else {
return kUTTypeJPEG as String
return UTType.jpeg.identifier
}
return uti
}
Expand All @@ -123,7 +123,7 @@ private extension MediaAssetExporter {
/// - parameter onError: Called if an error was encountered during export.
///
private func exportGIF(forAsset asset: PHAsset, resource: PHAssetResource, onCompletion: @escaping MediaExportCompletion) {
guard UTTypeEqual(resource.uniformTypeIdentifier as CFString, kUTTypeGIF) else {
guard resource.uniformTypeIdentifier == UTType.gif.identifier else {
onCompletion(nil, AssetExportError.expectedPHAssetGIFType)
return
}
Expand Down
3 changes: 2 additions & 1 deletion Yosemite/Yosemite/Tools/Media/MediaImageExporter.swift
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Foundation
import UniformTypeIdentifiers
import MobileCoreServices

/// Available options for an image export.
Expand Down Expand Up @@ -75,7 +76,7 @@ final class MediaImageExporter: MediaExporter {
typeHint: String?,
onCompletion: @escaping MediaExportCompletion) {
do {
let hint = typeHint ?? kUTTypeJPEG as String
let hint = typeHint ?? UTType.jpeg.identifier
let sourceOptions: [String: Any] = [kCGImageSourceTypeIdentifierHint as String: hint as CFString]
guard let source = CGImageSourceCreateWithData(data as CFData, sourceOptions as CFDictionary) else {
throw ImageExportError.imageSourceCreationWithDataFailed
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import MobileCoreServices
import XCTest
import UniformTypeIdentifiers
@testable import Yosemite

final class MediaImageExporterTests: XCTestCase {
func testExportingAnImageWithTypeHint() {
// Loads the test image into png data.
let mockData = UIImage(named: "image", in: Bundle(for: type(of: self)), compatibleWith: nil)!.pngData()
let filename = "test"
let typeHint = kUTTypeJPEG as String
let typeHint = UTType.jpeg.identifier
let mockImageSourceWriter = MockImageSourceWriter()
let exporter = MediaImageExporter(data: mockData!,
filename: filename,
Expand Down Expand Up @@ -65,7 +66,7 @@ final class MediaImageExporterTests: XCTestCase {
func testExportingNonImageData() {
let mockData = Data()
let filename = "test"
let typeHint = kUTTypeJPEG as String
let typeHint = UTType.jpeg.identifier
let mockImageSourceWriter = MockImageSourceWriter()
let exporter = MediaImageExporter(data: mockData,
filename: filename,
Expand Down
7 changes: 4 additions & 3 deletions Yosemite/YosemiteTests/Tools/Media/URL+MediaTests.swift
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import MobileCoreServices
import XCTest
import UniformTypeIdentifiers
@testable import Yosemite

final class URL_MediaTests: XCTestCase {
Expand Down Expand Up @@ -38,16 +39,16 @@ final class URL_MediaTests: XCTestCase {

func testFileExtensionForJPEGType() {
let expectedFileExtension = "jpeg"
XCTAssertEqual(URL.fileExtensionForUTType(kUTTypeJPEG as String), expectedFileExtension)
XCTAssertEqual(URL.fileExtensionForUTType(UTType.jpeg.identifier), expectedFileExtension)
}

func testFileExtensionForGIFType() {
let expectedFileExtension = "gif"
XCTAssertEqual(URL.fileExtensionForUTType(kUTTypeGIF as String), expectedFileExtension)
XCTAssertEqual(URL.fileExtensionForUTType(UTType.gif.identifier), expectedFileExtension)
}

func testFileExtensionForPNGType() {
let expectedFileExtension = "png"
XCTAssertEqual(URL.fileExtensionForUTType(kUTTypePNG as String), expectedFileExtension)
XCTAssertEqual(URL.fileExtensionForUTType(UTType.png.identifier), expectedFileExtension)
}
}