-
Notifications
You must be signed in to change notification settings - Fork 121
Store creation M2: show store summary after store creation success #8109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ow the store summary screen on success.
You can test the changes from this Pull Request by:
|
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
| } | ||
| } | ||
|
|
||
| required dynamic init?(coder aDecoder: NSCoder) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we can also add an @available attribute here to signal the compiler in compile-time that this initializer is not ready for use:
| required dynamic init?(coder aDecoder: NSCoder) { | |
| @available(*, unavailable) | |
| required dynamic init?(coder aDecoder: NSCoder) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, updated in b0b8bf9
Part of #8106
⚠️ Please only review this PR when the base PR #8107 is approved without critical suggestions
Description
After domain selection and before IAP, we need to create a free site and then pass the site ID for purchasing the eCommerce plan via IAP. This PR integrates the site creation backend and UI, where the tap to continue a selected domain triggers the site creation API request and shows a spinner in the CTA at the same time. After site creation success,
StoreCreationCoordinatornavigates to a new screen added in this PR,StoreCreationSummaryView, wrapped in a hosting controller. In case of site creation failure, an error alert is shown (we can polish the error state later).Testing instructions
Switch store+ Add a storeCreate a new store--> the domain selector should be shownScreenshots
I tested the domain error path by hard-coding the domain to be an empty string in the site creation request.
RELEASE-NOTES.txtif necessary.