Store creation M2: show store summary after store creation success #8109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow the store summary screen on success.
jaclync
added
type: enhancement
Collaborator
You can test the changes from this Pull Request by:
|
itsmeichigo
approved these changes
Nov 15, 2022
| } | ||
| } | ||
|
|
||
| required dynamic init?(coder aDecoder: NSCoder) { |
Contributor
There was a problem hiding this comment.
Nit: we can also add an @available attribute here to signal the compiler in compile-time that this initializer is not ready for use:
Suggested change
| required dynamic init?(coder aDecoder: NSCoder) { | |
| @available(*, unavailable) | |
| required dynamic init?(coder aDecoder: NSCoder) { |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8106
⚠️ Please only review this PR when the base PR #8107 is approved without critical suggestions
Description
After domain selection and before IAP, we need to create a free site and then pass the site ID for purchasing the eCommerce plan via IAP. This PR integrates the site creation backend and UI, where the tap to continue a selected domain triggers the site creation API request and shows a spinner in the CTA at the same time. After site creation success,
StoreCreationCoordinatornavigates to a new screen added in this PR,StoreCreationSummaryView, wrapped in a hosting controller. In case of site creation failure, an error alert is shown (we can polish the error state later).Testing instructions
Switch store+ Add a storeCreate a new store--> the domain selector should be shownScreenshots
I tested the domain error path by hard-coding the domain to be an empty string in the site creation request.
RELEASE-NOTES.txtif necessary.