Skip to content

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Nov 15, 2022

Closes: #8122

Description

As we had a few test IAP transactions that ended up in production because the sandbox billing mode was not enabled when testing, I wanted to propose the addition of a warning text and an alert reminder before purchasing a product in our IAP debug screen. we add a warning text instead of the IAP Debug Menu if the sandbox URL was not set in the WooCommerce Xcode schema.

Testing instructions

No WPCOM Sandbox URL in the WooCommerce schema environment variable

Open the IAP Debug screen. A warning text should appear instead of the IAP Debug menu:

WPCOM Sandbox URL in the WooCommerce schema environment variable is setup

Open the IAP Debug screen. You should see the IAP Debug Menu as usual.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@toupper toupper added type: task An internally driven task. feature: in-app purchases Related to In-app purchases and subscriptions labels Nov 15, 2022
@toupper toupper added this to the 11.3 milestone Nov 15, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 15, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8123-9282886 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@toupper toupper requested a review from koke November 15, 2022 14:22
Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I'd add an alert every single time you try to purchase. Could we look first at whether wpcom-api-base-url is set and maybe replace the whole thing with the warning if it's not? That seems less intrusive and would work as long as we don't want to use this to test in production.

@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@toupper toupper requested a review from koke November 15, 2022 16:32
@toupper
Copy link
Contributor Author

toupper commented Nov 15, 2022

@koke Sure, please take a look now.

Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! :shipit:

# Conflicts:
#	WooCommerce/Classes/ViewRelated/InAppPurchases/InAppPurchasesDebugView.swift
@toupper toupper enabled auto-merge November 16, 2022 13:50
@toupper toupper merged commit 80ee6a0 into trunk Nov 16, 2022
@toupper toupper deleted the issue/8122-iap-debug-warning-sandbox-mode branch November 16, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: in-app purchases Related to In-app purchases and subscriptions type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Sandbox-mode warning to IAP Debug Screen

4 participants