Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Nov 16, 2022

Closes: #8086

Description

StripeTerminal 2.14 is required for Tap on Mobile work in sTAP Away. Updating to this version in the production version of the app will make the development process much easier, as we can't change dependencies based on feature flags.

Testing instructions

Run unit tests

Test card reader payment flows. I've checked the following:

Connection

  • Connection during payment flow (take a payment with no connected reader)
  • Connection from Payments menu
  • Connection of a reader with a mandatory update: starts update process
  • Connection of M2 reader
  • Connection of WisePad 3 reader
  • Connection of Chipper reader

Payment

  • Take payment after in-line connection process
  • Take payment with a previously-connected reader
  • Take Interac payment
  • Refund Interac payment
  • Take contactless payment
  • Take card-inserted payment

Update reader

  • Reader update: error message when attempted with low battery
  • Reader update: successfully updates software and starts payment (in that flow) when complete

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8132-4166638 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@joshheald joshheald added feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task. labels Nov 16, 2022
@joshheald joshheald added this to the 11.3 milestone Nov 16, 2022
@joshheald joshheald marked this pull request as ready for review November 16, 2022 12:06
@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@iamgabrielma iamgabrielma self-assigned this Nov 17, 2022
@iamgabrielma
Copy link
Contributor

iamgabrielma commented Nov 17, 2022

Connection:

  • Connection during payment flow (take a payment with no connected reader)
  • Connection from Payments menu
  • Connection of a reader with a mandatory update: starts update process
  • Connection of M2 reader (STRM2SIMULATOR1)
  • Connection of WisePad 3 reader (WPC32SIMULATOR1)
  • Connection of Chipper reader (CBH20SIMULATOR1)

Payment:

  • Take payment after in-line connection process
  • Take payment with a previously-connected reader
  • Take Interac payment
  • Refund Interac payment
  • Take contactless payment
  • Take card-inserted payment

Update reader:

  • Reader update: error message when attempted with low battery
  • Reader update: successfully updates software and starts payment (in that flow) when complete

Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only test I couldn't perform is the Interac refund, as I don't have the physical WisePad3 reader. I was also able to refund an Interac refund via the simulator 👍

@joshheald joshheald merged commit eb9f382 into trunk Nov 18, 2022
@joshheald joshheald deleted the task/update-StripeTerminal-to-2.14 branch November 18, 2022 11:27
@joshheald joshheald restored the task/update-StripeTerminal-to-2.14 branch November 24, 2022 10:13
@joshheald joshheald deleted the task/update-StripeTerminal-to-2.14 branch November 24, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mobile Payments] Update StripeTerminal to 2.14

4 participants